As a character, he was definitely over but he was severely limited as a worker, which was fine when he and the company were on the same page but I think his inability to look at the bigger picture kept him back a little.
I think he was booked wrong during his 1990-91 title run. He did the unthinkable by pinning Hogan clean in the middle at Wrestlemania, but they gave him Rick Rude as his first feud (who he feuded with most of '89) and then he was involved in the LOD/Demolition feud all summer. He started a feud with Savage in the fall over the title, but they took the belt off of him in the middle of it. Yes, we got the GREAT Career vs. Career match at WM7 (EASILY Warrior's best match), but that should have been the Main Event of WM for the title.
I would agree that the Rude program went on way too long without any real meat to it. Rude didn't really get any real heat on him and while he was a great worker, there was only so much you could do with that program.
I think the weak title run booking came down to just how many people would work with Warrior and how limited he was in terms of getting them over.
I'll disagree that Warrior vs. Savage for the belt would have been better booking. We watched heel Savage chase Hogan for the title for almost year from WM5 up until a month prior to WM6. The emotion of the match came from it being the most significant career-ending match ever booked up until that point and without that, you lose the entire emotional backbone of the match. The crowd would have cared far less about it and you'd lose the Miss Elizabeth payoff (or at least have to rework it in a way that wouldn't be nearly as good).
I would have given Warrior the hot new Monster Heel Earthquake at Summerslam as him slamming Quake would have been almost as memorable as Hulk slamming Andre. Then I would have had him feud with Savage and then go on to feud with Jake as planned and later Undertaker (whom he did feud with) and Sid later on over the belt.
I will definitely disagree with that as well. Warrior's track record with monster heels was abysmal. He often wanted to go over quick in shitty squash matches that did nothing to generate heat for the heel. Hogan, for all his faults, got close to eighteen months worth of business, with Andre after Mania 3. Hogan understood the psychology of at least letting the big man appear unstoppable so that the crowd would mark out for the comeback. Warrior never really got that. He went through Andre like wet paper in most of their house show matches in 1989. He did that with Sid in 1992 and briefly with Vader in 1996. Warrior slamming Quake would unlikely have had anywhere near the impact because I doubt he would have the patience to make it work or the work rate to get it done. Hogan slamming Andre came off big because he sold it like he fucked up his back trying it at the start of the match, creating the impression that it couldn't be done then and he now was badly injured.